[En-Nut-Discussion] Features instead of Targets. was: memory boundary

Matthias Ringwald mringwal at inf.ethz.ch
Fri Apr 9 20:19:20 CEST 2004


HI

On 09.04.2004, at 09:25, TYOU wrote:

> Hi,
> Just had a look of the latest codes and found a bug:
> *************************
> #if defined(__arm__) || defined(__m68k__) || defined(__H8300H__) || 
> defined(__H8300S__) || defined(__linux__) || defined(__APPLE__)
>    /*
> ..

> #endif
> **************************
>
> for 32bit data in ARM or x86 platform, the boundary sould be 4.

I cannot confirm this, but

> so..maybe it is better use like "def MEM_ALIGN" as in my port to 
> shorten the "#if defined (........"I

I do agree that those #if defined()... lines should be shortened and 
based on features not on architectures.
so better define ARCH32 at a central place like in compiler.h instead 
of several times whenever it is needed.
I confirm me guilty in adding the last two defines everywhere ( 
__linux__ and __APPLE__)
but will help to clean them out.

matthias




More information about the En-Nut-Discussion mailing list