AW: [En-Nut-Discussion] Chat module memory leaks

[Oliver Schulz]

Hi Louis,

because you're using a diff format, that I don't know (looks a bit too simple), it's hard to recognize to which version of the source file you made that diff. I assume the file is /dev/chat.c, but we have several releases and some current development, where especially the line numbers are shifted and so on....

Can you tell me what release you're using, or better tell me the version number from the file. You can find the version number after the copyright annotation.

..or just use the GNU diffutils. :-)

Oliver.


> -----Ursprüngliche Nachricht-----
> Von: en-nut-discussion-bounces at egnite.de
> [mailto:en-nut-discussion-bounces at egnite.de]Im Auftrag von Louis
> Beaudoin
> Gesendet: Dienstag, 11. Mai 2004 21:23
> An: en-nut-discussion at egnite.de
> Betreff: [En-Nut-Discussion] Chat module memory leaks
> 
> 
> Hi all,
> 
> The chat module loses memory when using the "REPORT" command.  The 
> report buffer is allocated more than once, and the report 
> search buffer 
> is not freed when the NUTCHAT structure is destroyed.
> 
> Additionally, the '^' character cannot be sent with the current code, 
> and our modem, the Siemens MC56 uses this in AT commands.  I added 
> support for this character by sending "\^"
> 
> Diff below
> 
> Thanks,
> Louis Beaudoin
> 
> 201a204,206
>  >             case '^':
>  >                 ch = '^';
>  >                 break;
> 339a351,353
>  >                 case '^':
>  >                     *cp++ = '^';
>  >                     break;
> 384c398
> <         chat_report = malloc(CHAT_MAX_REPORT_SIZE+1);
> ---
>  >         if(!chat_report)
> 384a399
>  >             chat_report = malloc(CHAT_MAX_REPORT_SIZE+1);
> 429a445,446
>  >         if(ci->chat_report_search)
>  >             free(ci->chat_report_search);
> 
> _______________________________________________
> En-Nut-Discussion mailing list
> En-Nut-Discussion at egnite.de
> http://www.egnite.de/mailman/listinfo.cgi/en-nut-discussion
>