[En-Nut-Discussion] SVN compilation fix: fs/fat.c

Uwe Bonnes bon at elektron.ikp.physik.tu-darmstadt.de
Sun Oct 18 18:07:15 CEST 2009


>>>>> "Thiago" == Thiago A Corrêa <thiago.correa at gmail.com> writes:

    Thiago> Hi, On Mon, Oct 5, 2009 at 1:35 PM, Uwe Bonnes
    Thiago> <bon at elektron.ikp.physik.tu-darmstadt.de> wrote:
    >> -    BYTE firstsek_LEpathtab1_LE[4]; -    BYTE
    >> firstsek_LEpathtab2_LE[4]; +    DWORD firstsek_LEpathtab1_LE; +  
    >>  DWORD firstsek_LEpathtab2_LE;

    Thiago> I don't currently use this driver, but looks reasonable. Perhaps
    Thiago> we should actually change all BYTE to uint8_t and all DWORD to
    Thiago> uint32_t like the rest of the Nut/OS. The _t types are quite
    Thiago> carefully defined, can't say if those upper letter types are.

Well, the "rest of Nut/OS" still also isn't free of BYTE/WORD/DWORD etc,
especially in the AVR tree

> find nut/ -name \*.c | xargs grep " BYTE " | cut -d ':' -f 1 | sort | uniq 
nut/arch/avr/dev/ide.c
nut/arch/avr/dev/pcmcia.c
nut/arch/avr/dev/wlandrv.c
nut/fs/fat.c

So I vote to apply my initial patch first, and then to clean up the BYTE etc
situation in another step.

Bye
-- 
Uwe Bonnes                bon at elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------



More information about the En-Nut-Discussion mailing list