[En-Nut-Discussion] Tons of trailing spaces in our source code
Ulrich Prinz
uprinz2 at netscape.net
Wed Oct 20 00:05:33 CEST 2010
To do a summary:
We had some rules for the past years of how to write code and there is
no need to change them. I fully agree.
What I read is that there is no interest to do an overall clean up of
the code with some beautifier tools. That's what I told too but may be
it was misunderstood. But there is, with respect to several diff tools,
an interest to cleanup tabs and trailing spaces.
So my idea is that we find a configurable existing beautifier or write a
simple command line tool that recursively corrects only these two
issues. If we write the tool we could integrate it into the tools path
and may be integrate it into the make process with a certain command.
With or without the tool we should urge the contributors to keep an eye
on tabs and spaces.
If we do a simple cleanup commit (with or without increasing the version
number) we should do one additional thing:
We should try to update all copyright headers to the latest version and
we should add the actual valid $ID:$ token below it. Cause there are
still different copyright headers in the sources and there are files
that have the old 10 pages of change information after the header but
the SVN ID token is missing.
I am not sure if that header check can be done by the tool too, that Ole
has in mind. But there should be a way to add this $Id:$
/*
* \verbatim
* $Id: stm32_usart.c 3143 2010-09-29 20:13:51Z Astralix $
* \endverbatim
*/
Ah, The $Id:$ Token is actual only activated in the branch of the
devnut_m2n/arch/cm3 sub tree, but the one who commits the cleanup can
activate that in a single step in that commit run too.
How about that compromise?
Best regards
Ulrich
More information about the En-Nut-Discussion
mailing list