[En-Nut-Discussion] UART Flow Control Broken?

[Ole Reinhardt]

Hi Harald and Ulrich,

> I discovered, that CM3 re-integration added
> [...]
> Most probably this refers to the following comment
> 
> "usart.c mode_flags where not sent to driver correctly for all architectures: fixed."
> 
> If I didn't miss anything, XON/XOFF handshake is now automatically enabled each time _ioctl(UART_SETFLOWCONTROL) is called. In that case extra characters XON or XOFF may be added to the stream.

Indeed, this is definitely wrong. 

Ulrich: AFAIK you did this modification?

I think his intention was to set the modeflags depending on the
handshake mode given as parameter to the ioctrl and then call the
dcb_set_flow_control accordingly. But as the modeflags contain many more
flags beside of the flow-control, we should not pass them unfiltered to
the dbc_set_flow_control, right?

> As this applies to all platforms: Does anybody else have RTC/CTS handshake working since version 5.0.4?

Sorry, I did not use it for a long time.

Bye,

Ole

-- 

Thermotemp GmbH, Embedded-IT

Embedded Hard-/ Software and Open Source Development, 
Integration and Consulting

http://www.embedded-it.de

Geschäftsstelle Siegen - Steinstraße 67 - D-57072 Siegen - 
tel +49 (0)271 5513597, +49 (0)271-73681 - fax +49 (0)271 736 97

Hauptsitz - Hademarscher Weg 7 - 13503 Berlin
Tel +49 (0)30 4315205 - Fax +49 (0)30 43665002
Geschäftsführer: Jörg Friedrichs, Ole Reinhardt
Handelsregister Berlin Charlottenburg HRB 45978 UstID DE 156329280