[En-Nut-Discussion] HEARTBEAT_IDLE_LED

[Harald Kipp]

Hi,

there seems to be something wrong with the recent implementation of HEARTBEAT_IDLE_LED_ON and HEARTBEAT_IDLE_LED_OFF in the trunk.

As far as I understood the code, they are defined, if HEARTBEAT_IDLE_PIN and HEARTBEAT_IDLE_PORT are defined. However, they are used if __GNUC__ and __AVR_ENHANCED__ are defined. That means, it will fail to compile with GCC for all boards with enhanced ATmega CPUs. And that's exactly what it does right now.

------------------------------------------------------------------------
Target : arthernet1-avr-gcc-bld
Command: SET PATH=e:\ethernut\nut-trunk\nut\tools\win32;e:\WinAVR\bin;e:\WinAVR\utils\bin;e:\apps\bin;%SystemRoot%\system32;%SystemR
oot%;%SystemRoot%\System32\Wbem;&make clean all install
Error  : 2
------------------------------------------------------------------------
avr-gcc -c -I../../arthernet1-avr-gcc-bld/include  -I../.././nut/include  -DARTHERNET1 -D__HARVARD_ARCH__  -MD -MP -mmcu=atmega128 -
Os -fno-delete-null-pointer-checks -Wall -Wstrict-prototypes -Werror -Wa,-a=nutinit.lst  -o nutinit.o ../.././nut/os/nutinit.c
In file included from ../.././nut/os/nutinit.c:74:
../.././nut/os/../arch/avr/os/nutinit.c: In function 'NutIdle':
../.././nut/os/../arch/avr/os/nutinit.c:300: error: 'HEARTBEAT_IDLE_LED_OFF' undeclared (first use in this function)
../.././nut/os/../arch/avr/os/nutinit.c:300: error: (Each undeclared identifier is reported only once
../.././nut/os/../arch/avr/os/nutinit.c:300: error: for each function it appears in.)
../.././nut/os/../arch/avr/os/nutinit.c:306: error: 'HEARTBEAT_IDLE_LED_ON' undeclared (first use in this function)
make[1]: *** [nutinit.o] Error 1
make[1]: Leaving directory `E:/ethernut/ethernut-5.0.5/arthernet1-avr-gcc-bld/os'
make: *** [all] Error 2

Regards,

Harald