[En-Nut-Discussion] include/crypto/bigint.h vs ./include/contrib/crypto/bigint.h

[Ole Reinhardt]

Hi Uwe,

Am 24.04.2014 12:15, schrieb Uwe Bonnes:
> I added some GPL contrib in my private branches and so added
> LICENSE_GPL3 = ""
> in my config. I know the contrib directories compiled before, but now
> I get tons of errors like:
> contrib/arm-crypto-lib/bigint/bigint.c:130:18: error: unknown type name
> 'bigint_t'

You run into trouble caused by the same naming of some header files,
which I was not aware of, when adding the TLS library code to the repo.


> Harald moved Thu Jan 24 12:23:51 2013 +0000
>  nut/include/contrib/crypto/bigint.h | 76 ++++++++++++++++++++++++++++++++++
>  nut/include/crypto/bigint.h         | 76 ---------------------------------
> 
> and Ole added Sun Mar 23 22:55:58 2014 +0000
> nut/include/crypto/bigint.h | 98 +++++++++++
> 
> nut/include/crypto/bigint.h   doesn't define bigint_t and so
> 
> but also changed before  Fri Oct 25 20:18:33 2013 +0000
> --- a/nut/contrib/arm-crypto-lib/bigint/bigint.c
> +++ b/nut/contrib/arm-crypto-lib/bigint/bigint.c
> -#include "bigint.h"
> +#include <crypto/bigint.h>
> 
> Now the new nut/include/crypto/bigint.h is included having no definition of
> bigint_t.

These are two totally different libraries. The one from Daniel Otte
(GPL), which now lives in nut/contrib/arm-crypto-lib, and the axTLS
library (BSD), which lives int nut/crypto and nut/tls.

When enabling the GPL support, the GPLed arm-crypto-lib is compiled,
which includes its own headers of the same naming scheme.

My changes on "Fri Oct 25 20:18:33 2013 +0000" have been made to make
the arm-crypto-lib to compile along with Nut/OS at all, before it had to
be compiled seperately.

I suppose that we have to look over the makefiles and includes ones
again to make sure, the right files are included in the arm-crypto-lib.
Very likely the main problem is -I nut/include/contrib, added somewhere
in the makefiles.

Bye,

Ole



-- 
kernel concepts GmbH            Tel: +49-271-771091-14
Sieghuetter Hauptweg 48         Mob: +49-177-7420433
D-57072 Siegen
http://www.embedded-it.de
http://www.kernelconcepts.de