AW: [En-Nut-Discussion] PPP: compression reject, DNS

[Oliver Schulz]

Hi Michel,

please send me your changes to my private email, so the fixes will make their way in CVS soon.

Regards,
Oliver.

> -----Ursprüngliche Nachricht-----
> Von: Michel Hendriks [mailto:unreal at home.nl]
> Gesendet: Mittwoch, 14. Januar 2004 10:27
> An: en-nut-discussion at egnite.de
> Betreff: RE: [En-Nut-Discussion] PPP: compression reject, DNS
> 
> 
> Hi Mike,
> 
> Yes, you are right, the fix should be applied to LCP and 
> IPCP. But, while testing
> with more Internet providers I found that my fix was not good 
> enough. It fixes the
> case where all options are equal in length, but when options 
> that are rejected have
> different lengths it still fails.
> 
> I've made a proper fix to both lcpin.c and ipcpin.c and I 
> will post them soon.
> 
> Hope this helps,
> 
> Michel
> 
> Mike Cornelius said:
> > Hi All,
> >
> > Just noticed Michel's patch needs to be applied to lcpin.c too.
> > It works (or doesn't) exactly the same way.
> >
> > Actually Michel's first post says:-
> > "I'm having some difficulties with the LCP layer of the PPP stack."
> >
> > But the patch has only been applied to IPCP.
> >
> > Regards,
> >
> > Mike Cornelius
> >
> > -----Original Message-----
> > From: en-nut-discussion-bounces at egnite.de
> > [mailto:en-nut-discussion-bounces at egnite.de] On Behalf Of 
> Harald Kipp Sent:
> > Friday, December 19, 2003 7:17 AM
> > To: Ethernut User Chat (English)
> > Subject: RE: [En-Nut-Discussion] PPP: compression reject, DNS
> >
> >
> > Michel,
> >
> >
> >>Sorry it took so long, but I managed to find the problem.
> >>In the IpcpRxConfReq function the rejected option is copied 
> into the  reply. But
> >> it copies data from the previous option, not the option it 
>  is rejecting at that
> >> moment.
> >
> > I'm too tired to finally check your patch, but it
> > looks like you are fully right.
> >
> >
> >>Should I commit it to CVS? (Can I?)
> >
> > No, you can't. But everybody is invited to step up
> > to the developer status. But there are several
> > rules to be followed, at least 
> http://www.ethernut.de/en/developers.html
> >
> > Right now, Oliver Schulz is the only registered
> > developer with CVS write access. We could really
> > effort some more helping hands.
> >
> > For your patch, I'll add it tomorrow. Or Oliver
> > can do that, if he didn't fall asleep already. :-)
> >
> >
> >>BTW. I used the pppc sample to setup the nameserver and 
> default route  and it
> >> works perfectly. Many thanks.
> >
> > I have to thank you. I'm aware, how much hassle it
> > requires to track down these kind of problems. You
> > saved us all a lot of work.
> >
> > Harald
> >
> > _______________________________________________
> > En-Nut-Discussion mailing list
> > En-Nut-Discussion at egnite.de
> > http://www.egnite.de/mailman/listinfo.cgi/en-nut-discussion
> >
> > _______________________________________________
> > En-Nut-Discussion mailing list
> > En-Nut-Discussion at egnite.de
> > http://www.egnite.de/mailman/listinfo.cgi/en-nut-discussion
> 
> 
> 
> _______________________________________________
> En-Nut-Discussion mailing list
> En-Nut-Discussion at egnite.de
> http://www.egnite.de/mailman/listinfo.cgi/en-nut-discussion
>