[En-Nut-Discussion] PATCH: Fix signed/unsigned mismatch warnings

Harald Kipp harald.kipp at egnite.de
Sun Jun 12 10:56:51 CEST 2005


Hello Tim,

Sorry, I'm not the only developer with write access and I'm
currently busy with cleaning up Nut/OS timers. Changing unsigned
to signed may break the code. Thus I'd not blindly apply this
patch without re-checking its consequences.

The main reason for having used u_char is sheer laziness. You
don't have to think about negative character values, which
appear in most European languages (8-bit ASCII) and certain
control codes.

Anyway, I agree that this issue must be addressed.

Harald

P.S. Please try to limit the size of the mailing list archives.
Instead of reposting a large patch, which became unusable by
quoting, a link to the archive entry would have been preferred.

At 11:44 11.06.2005 +0200, you wrote:
>Hi,
>my gcc 4.0 complains about this u_char, too.
>The reason is another parameter type in the string functions
>in avr-libc v1.2.3.
>Is there a obvious reason for the unsinged char type?
>Or can we switch easily to the signed version?
>Harald could you please merge a patch to the cvs HEAD?
>
>Tim




More information about the En-Nut-Discussion mailing list