[En-Nut-Discussion] Regression bug in HDLC_SETIFNET ?

[Vesa Jääskeläinen]

Vesa Jääskeläinen wrote:

> I am using devAhdlc1 to communicate with modem. I had old code using 
> this with prior NutOS and it worked fine. I am using newest sources from 
> CVS for testing this out.
> 
> Any suggestions are welcome.

At least there is problem in thread AhdlcRx. When PPP session is opened 
for the first time there is no way AhdlcRx to end second for-loop 
processing packets.

If I add following patch, then it does get out of the loop, but still 
doesn't work as it should. If I first start ppp session and then start 
terminating it:

_ioctl(pppcom, LCP_CLOSE, 0);

and after a while:

_ioctl(pppcom, HDLC_SETIFNET, 0);

It seems to works "correctly", only problem is that +++ & ATH isn't sent 
to serial device.

If connection is not yet made, it seems to reboot AVR after that patch.

diff -u -r1.7 ahdlcavr.c
--- ahdlcavr.c  10 Feb 2005 07:06:17 -0000      1.7
+++ ahdlcavr.c  24 Mar 2005 14:16:10 -0000
@@ -431,6 +431,9 @@
                  }
              }

+            if (dev->dev_icb == 0)
+                break;
+
              ch = dcb->dcb_rx_buf[dcb->dcb_rd_idx++];

              if (inframe) {