[En-Nut-Discussion] error in ipin.c?!

[llsoft at quantentunnel.de]

Hi,

currently I'm extending Nut/Net for multicast.
I found maybe an error in "ipin.c"

In function NutIpInput an ICMP response 'unreachable protocol' is sent if the protocol is unknown.
According to RFC 1122, section 3.2.2, no icmp response should be sent if destination address was broadcast or multicast.
Therefore, almost at the end of the function, the line before freeing the net buffer

 if (!NutIcmpResponse(ICMP_UNREACH, ICMP_UNREACH_PROTOCOL, 0, nb))

should be changed to

 if (bcast || !NutIcmpResponse(ICMP_UNREACH, ICMP_UNREACH_PROTOCOL, 0, nb))


Am I right?

Jan

-- 


"Feel free" – 10 GB Mailbox, 100 FreeSMS/Monat ...
Jetzt GMX TopMail testen: http://www.gmx.net/de/go/topmail