[En-Nut-Discussion] Tons of trailing spaces in our source code

[Ulrich Prinz]

Hi!

Yipppea! That's one of my wishes for long time: Fight the trailing spaces!

Yes, my editor is auto-removing them, but not selective. If I change one 
single character in a file, with the next save the whole file is 
cleaned. And I keep that option on as long as there is one of them left 
in the whole code.

But I am using Nut/OS mostly under Windows so I have a fortune. I use 
Tortoise SVN and I do not click Commit->OK, but since some times I only 
start the commit and then doubleclick all files and check if they only 
contain space-fixes. In that case I deselect them and commit them in a 
separate run. Might be an idea for you other guys too?

But, Harald, it's not only you who introduces new trailing spaces, there 
are others too. I don't want to point out, but one of them is really 
busy in the AVR32 scene :)

Best regards
Ulrich

Am 13.10.2010 19:56, schrieb Harald Kipp:
> Hi all,
>
> I'm mainly using MS Visual Studio for editing source files. The problem
> is, that this editor doesn't automatically remove trailing spaces.
> Worse, it often adds them and it's hard to detect or avoid them. As a
> result, I'm guilty for most of the trailing spaces. Sorry, guys, it's
> not me, it's "The Borg". ;-)
>
> Recently I installed an add-on, which removes trailing spaces. The
> problem now is, that this is done automatically, beyond my control.
> Committing changes may result in a large amount of changed lines, which
> makes it nearly impossible to follow the intended code changes.
>
> I assume, that Ulrich has similar problems, because his commits often
> include code changes and lines (my) with trailing spaces removed. In
> order to fix this now and for all times, two actions are required:
>
> 1. Files containing trailing whitespace should have it removed and
> committed first before further patching.
> 2. I will stop contaminating the code with trailing whitespace.
>
> Thanks,
>
> Harald
>
> P.S.: I wonder if Ulrich added the phrase "Lots of trailing space
> removement" by default to his commit message. ;-) At least rev-3168
> claims this, but luckily only code changes had been committed.
> _______________________________________________
> http://lists.egnite.de/mailman/listinfo/en-nut-discussion