[En-Nut-Discussion] Removed LICENSE_LUMINARY_ANTI_VIRAL requirement for cortex3
harald.kipp at egnite.de
Thu Aug 30 11:22:20 CEST 2012
On 30.08.2012 10:32, Uwe Bonnes wrote:
> Harald> We are not allowed to replace existing license headers unless we
> Harald> have an explicit permission from the copyright holders. I assume
> Harald> that you don't have, so please revert this change.
> Harald> I'd also suggest to keep the original file names. interrupt.c is
> Harald> sufficient, we do not need to prepend it with cortex, as it is
> Harald> already placed in the cm3 tree.
> Unique names help in the debugger, with backtraces etc. But as there is no
> other interrupt.c in our source yet, the name is good.
I'm not often using a debugger, but is that really true? Just wondering because the debug info includes path information.
> What about following way:
> Check in the recent stellarislib/interrupt.c
> Extract the needed changes from cortex_interrupt.c
> Replace references to cortex_interrupt.c with interrupt.c
> Remove the license requirements.
> However as I don't have the original luminary/interrupt.c, we are not sure
> if the extracted changes are our changes or code from the original file :-(
Indeed, that's a real problem. Except Ole's re-integration, subversion hadn't been properly used to maintain the repository's history. But even then it is a difficult problem. Not really sure about parts that had been contributed to a file under a wrong license. May be we should ask someone, who is more familiar with this lawyer stuff.
Have you ever checked, how much needs to be changed? May be it is not that much and could be done in a few hours. Several people can help to test it, as soon as it compiles.
More information about the En-Nut-Discussion