[En-Nut-Discussion] Ethernut on TI's Cortex-M3 (Stellaris LM3S...)

Uwe Bonnes bon at elektron.ikp.physik.tu-darmstadt.de
Thu Oct 11 18:56:44 CEST 2012


>>>>> "Ole" == Ole Reinhardt <ole.reinhardt at embedded-it.de> writes:


    Ole> - Further you created

    Ole>   nut/include/arch/cm3/lm3/vendor/lm3s9b96.h

    Ole>   Better place it in

    Ole>   nut/include/arch/cm3/lm3/lm3s9b96.h

    Ole>   Why the "vendor" subtree?

I proposed to put vendor files with few adaptations in a "vendor" branch
e.g. arch/cm3/lm3/vendor/. Files writen by the Ethernut community would go
in arch/cm3/lm3/

include/arch/cm3/lm3/vendor/lm3s9b96.h is clearly taken from the Stellaris
libraries :
+//**************************************************************************
+//
+// lm3s9b96.h - LM3S9B96 Register Definitions
+//
+// Copyright (c) 2009-2012 Texas Instruments Incorporated.  \
        All rights reserved.
+// Software License Agreement
+// 

That way we have a clean survey of what is "ours" and what "theirs". Would
that do any harm? I regret that STM32 is not done that way.

And I also strongly suggest to check in the _unaltered_ files from external
libraries first. Then changes to that file are other checkins. That way if
the external library updates, we can much easier recreate the changes.

Bye
-- 
Uwe Bonnes                bon at elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------


More information about the En-Nut-Discussion mailing list