[En-Nut-Discussion] Thoughts about TCP stack potability changes

[Ole Reinhardt]

Hi Michael,

First of all: I wish you and all others a happy and prosperous new year!


I noticed, that you changed some APIs a few days ago to enhance
portability of the stack.

To what platform do you plan to port the stack? And why did you need
these changes?

Even if your changes does not break any existing code, they will lead to
some confusion for new (and perhaps also existing) users.

I noticed, that you introduced a new "type" NUTEVENT, which now replaces
HANDLE in the NutEvent api, while you also added a #define from NUTEVENT
to HANDLE. So finally you just renamed the type.

But these changes will find its way into the Ethernut API documentation
and will there lead to confusion.

I would like to suggest the following:

- Either completely change the API usage to the new type name
  ==> Replace all occurance of HANDLE by NUTEVENT,

or

- Revert the changes and find another way, e.g. by doing the #define
  the other way round:

  #define HANDLE NUTEVENT

Perhaps things become clearer to me if you could explain your plan a
little more in detail.

It might also be a good idea to first create a branch and implement the
changes there. So you could first test everything and finally
re-integrate it into the mainline code?

Best regards,

Ole

-- 
kernel concepts GmbH            Tel: +49-271-771091-14
Sieghuetter Hauptweg 48         Mob: +49-177-7420433
D-57072 Siegen
http://www.embedded-it.de
http://www.kernelconcepts.de