[En-Nut-Discussion] Extra packet in ethernet packet

[Coleman Brumley]

Uwe,

I've not looked to see if this was removed in the latest code base. 

I do not have SVN rights that I know of. 

> arch/arm/dev/atmel/at91sam7x_emac.c is marked obsolete and not
> referenced in our build system. Any reason not to remove this file?

Why is marked as obsolete? Has the driver been merged with a unified driver
or something?

Coleman

> -----Original Message-----
> From: Uwe Bonnes [mailto:bon at elektron.ikp.physik.tu-darmstadt.de]
> Sent: Friday, June 12, 2015 12:38 PM
> To: cbrumley at polarsoft.biz; Ethernut User Chat (English)
> Subject: Re: [En-Nut-Discussion] Extra packet in ethernet packet
> 
> >>>>> "Coleman" == Coleman Brumley <cbrumley at polarsoft.biz> writes:
> 
>     Coleman> The code should be modified as follows: sz += nb->nb_dl.sz;
>     Coleman> //if (sz & 1) { // sz++; //}
> 
>     Coleman> Since the AT91 EMAC isn't limited to only sending odd or even
>     Coleman> bytes, there is no need to check.
> 
> Coleman,
> 
> stm32 and nxp emacs already don't have that code active.
> arch/arm/dev/atmel/at91sam7x_emac.c is marked obsolete and not
> referenced in our build system. Any reason not to remove this file?
> 
> Did you check for the AT91 driver on SAM7 and SAM3? If the restriction
> doesn't apply for any AT91 emacs, the code should be removed. If you don't
> have SVN access rights, please let me know.
> 
> Bye
> 
> --
> Uwe Bonnes                bon at elektron.ikp.physik.tu-darmstadt.de
> 
> Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
> --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------